-
Notifications
You must be signed in to change notification settings - Fork 26
<Issue-290> | Supports integration with pubsub emulator #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
91f2ee1
to
8be0913
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Please fix the formatting errors by running mvn com.coveo:fmt-maven-plugin:format
.
@matt-kwong Thanks for the review. I have fixed the formatting issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the failing build in the CI tests.
@@ -273,7 +273,13 @@ public ConfigDef config() { | |||
Type.STRING, | |||
ConnectorUtils.CPS_DEFAULT_ENDPOINT, | |||
Importance.LOW, | |||
"The Pub/Sub endpoint to use."); | |||
"The Pub/Sub endpoint to use.") | |||
.define( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there's only two options, I think it makes more sense to make this a boolean instead of a string. Maybe something like cps.useEmulator
that defaults to false
.
.setEndpoint(cpsEndpoint); | ||
.build()); | ||
|
||
log.info("CPS host value: {}", cpsHost); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's only add logging for when we connect to the emulator.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #290 ☕️
If you write sample code, please follow the samples format.