Skip to content

<Issue-290> | Supports integration with pubsub emulator #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iftekhar-khan09
Copy link

@iftekhar-khan09 iftekhar-khan09 commented May 23, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #290 ☕️

If you write sample code, please follow the samples format.

@iftekhar-khan09 iftekhar-khan09 requested review from a team as code owners May 23, 2025 18:48
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 23, 2025
@iftekhar-khan09 iftekhar-khan09 force-pushed the main branch 3 times, most recently from 91f2ee1 to 8be0913 Compare May 24, 2025 05:11
Copy link
Collaborator

@matt-kwong matt-kwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Please fix the formatting errors by running mvn com.coveo:fmt-maven-plugin:format.

@iftekhar-khan09
Copy link
Author

@matt-kwong Thanks for the review. I have fixed the formatting issue.

Copy link
Collaborator

@matt-kwong matt-kwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the failing build in the CI tests.

@@ -273,7 +273,13 @@ public ConfigDef config() {
Type.STRING,
ConnectorUtils.CPS_DEFAULT_ENDPOINT,
Importance.LOW,
"The Pub/Sub endpoint to use.");
"The Pub/Sub endpoint to use.")
.define(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there's only two options, I think it makes more sense to make this a boolean instead of a string. Maybe something like cps.useEmulator that defaults to false.

.setEndpoint(cpsEndpoint);
.build());

log.info("CPS host value: {}", cpsHost);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's only add logging for when we connect to the emulator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connector cps.endpoint config does not target emulator
2 participants