<Issue-290> | Supports integration with pubsub emulator #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iftekhar-khan09
force-pushed
the
main
branch
3 times, most recently
from
91f2ee1 to
8be0913
Compare
matt-kwong
requested changes
May 29, 2025
|
@matt-kwong Thanks for the review. I have fixed the formatting issue. |
matt-kwong
requested changes
Jun 3, 2025
| @@ -273,7 +273,13 @@ public ConfigDef config() { | |||
| Type.STRING, | |||
| ConnectorUtils.CPS_DEFAULT_ENDPOINT, | |||
| Importance.LOW, | |||
| "The Pub/Sub endpoint to use."); | |||
| "The Pub/Sub endpoint to use.") | |||
| .define( | |||
There was a problem hiding this comment.
Since there's only two options, I think it makes more sense to make this a boolean instead of a string. Maybe something like cps.useEmulator that defaults to false.
| .setEndpoint(cpsEndpoint); | ||
| .build()); | ||
|
|
||
| log.info("CPS host value: {}", cpsHost); |
There was a problem hiding this comment.
Let's only add logging for when we connect to the emulator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #290 ☕️
If you write sample code, please follow the samples format.